Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address hardcoded version number #58

Closed
PaulJWright opened this issue Nov 8, 2022 · 1 comment
Closed

Address hardcoded version number #58

PaulJWright opened this issue Nov 8, 2022 · 1 comment

Comments

@PaulJWright
Copy link

PaulJWright commented Nov 8, 2022

The most recent release on pypi was 0.93.3 4 months ago, however the version number is hardcoded in this repo here. This means that if a user installs through pip, or manually from git, currently they will believe they are on the same version.

I would recommend looking at how this is addressed by sunpy.

Example

through pip:

(eispac-testing) ➜  eispac git:(main) pip install eispac
(eispac-testing) ➜  eispac git:(main) ipython
Python 3.8.8 (default, Apr 13 2021, 12:59:45)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.22.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import eispac

In [2]: eispac.__version__
Out[2]: '0.93.3'

... or installing by cloning the repo:

(eispac-testing-2) ➜  eispac git:(main) pip install -e .
(eispac-testing-2) ➜  eispac git:(main) ipython
Python 3.8.8 (default, Apr 13 2021, 12:59:45)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.22.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import eispac

In [2]: eispac.__version__
Out[2]: '0.93.3'

RE: openjournals/joss-reviews#4914

@PaulJWright PaulJWright changed the title address hardcoded .__version__ address hardcoded version number Nov 8, 2022
@PaulJWright PaulJWright changed the title address hardcoded version number Address hardcoded version number Nov 8, 2022
@MJWeberg
Copy link
Collaborator

Finally added automatically updating version numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants