Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON reader & extractor #27

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Conversation

BeritJanssen
Copy link
Member

@BeritJanssen BeritJanssen commented Nov 21, 2024

Close #6. This proved more complicated than I first envisioned, because the example data I found happened to be structured as arrays within a dictionary. This solution can now tackle both types of data: single file with multiple documents, or a file per document.

Unfortunately, the pandas libary needs to be a higher version than available with Python 3.8 to flatten the JSON appropriately. Should we drop Python 3.8 support, seeing as it's beyond end of life now?

@lukavdplas
Copy link
Contributor

Apologies for the late response, I hadn't realised this was ready for review.

Before I review this, can you add relevant documentation changes in /docs and README.md? I would not have approved this without a documentation update, and it makes the rest of the review easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JSON extractor and reader
2 participants