Create an option to enable vtkweb #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,6 +73,12 @@ if(CDAT_BUILD_OFFSCREEN) | |||
| ) | |||
| endif() | |||
|
|
|||
| if(CDAT_BUILD_VTKWEB) | |||
There was a problem hiding this comment.
How about CDAT_ENABLE_WEB? Or CDAT_BUILD_WEB?
There was a problem hiding this comment.
CDAT_BUILD_* is consistent with the other options. To me, VTKWEB is more explicit unless there is something else that WEB will enable, but I don't have a strong opinion.
There was a problem hiding this comment.
I like that: CDAT_BUILD_VTKWEB
There was a problem hiding this comment.
@doutriaux1 we don't want to expose vtkweb. Web option in the future will enable more than just vtkWeb.
|
LGTM 👍 |
aashish24
added a commit
that referenced
this pull request
Feb 2, 2015
Create an option to enable vtkweb
|
Changes Unknown when pulling f0714ee on vtkweb-option into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It defaults to off so nothing should blow up.