Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider migrating to ruff instead of isort + black for code formatting/import sorting #91

Open
davenquinn opened this issue Sep 10, 2024 · 0 comments

Comments

@davenquinn
Copy link
Member

In #88 we merged automatic formatting of code. This works great but has a few problems:

isort's import formatting works differently from IntelliJ/PyCharm's built in capabilities (which don't appear configurable). The main difference is around "known first party" code (e.g., macrostrat.***) which isort allows grouping separately.

This creates a bit of a back-and-forth exchange between IntelliJ and CI-based formatting in some changes.

Switching to a newer/all-in-one tool like ruff might help things, but only if there is an IntelliJ/PyCharm integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant