Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UW http client #75

Open
mar235av opened this issue Jul 27, 2024 · 1 comment
Open

Update UW http client #75

mar235av opened this issue Jul 27, 2024 · 1 comment
Assignees

Comments

@mar235av
Copy link
Contributor

For connections to external web resources, such as GWS, we use a custom http client built using Apache HttpClient version 4.5.

Shibboleth 5.X has updated to the 5.3 version of HttpClient, which introduced significant changes to the API. There is a migration guide to assist in migrating applications to the new HttpClient API.

It is uncertain if it is possible to keep our existing code and include both versions of the HttpClient library, but this seems undesirable. Therefore, I'm going to at least explore what it takes to upgrade our client to the 5.3 version.

@mar235av mar235av self-assigned this Jul 27, 2024
@mar235av
Copy link
Contributor Author

Resolving this issue. Further analysis of the migration guide indicates that version 4.5 and version 5.3 of HttpClient can co-exist, they have different package structures and are thus completely independent.
Given that, I copied in the 4.5 library versions into the build (via edit-webapp/WEB-INF/lib, the same place the plugins are located), rebuilt and deployed the war file, which resolves the issue.
We should rewrite our web client for multiple reasons including this, but this work can be deferred until later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant