Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 8 compatibility #206

Closed
joevaugh4n opened this issue Feb 21, 2024 · 4 comments · Fixed by #210
Closed

Storybook 8 compatibility #206

joevaugh4n opened this issue Feb 21, 2024 · 4 comments · Fixed by #210

Comments

@joevaugh4n
Copy link

Hey all! I’m reaching out from the core SB team :)

Storybook 8 (our next major release) is coming soon, and it introduces some breaking changes that your addon might need to account for.

We’ve listed all the key changes in a new Storybook 8 migration guide, and we’d encourage you to check it out and see if your addon is impacted.

We also have an addons channel in our Discord community, which we’d like to use to better communicate with addon authors in the future. If you’re not part of the server, consider joining here and message me (@joevaugh4n) so that I can give you the addon creator role! If you’re already in the server, please just ping me and I’ll respond to you there.

Thanks for being a part of our addon community!

Joe

@Matt-Scoville
Copy link

Is there any update on this?

Since Storybook 8 has now been released. I'm looking to update my projects Storybook and it is telling me that the storybook-design-token addon is incompatible since it requires a different major version. It does seem to work however.

@hagealex
Copy link

Good morning everyone!

Same for me: I'm now working with Storybook 8 and would be very happy to use this addon :)

@Sqrrl
Copy link
Collaborator

Sqrrl commented Mar 15, 2024

Just merged #210. Thanks to @sod. Released with v3.1.0

@sod
Copy link
Contributor

sod commented Mar 15, 2024

Thanks a lot for releasing so fast @Sqrrl.

Who lands here because they get errors with storybook-design-token@3.1.0 + storybook@8 - be aware that storybook v8 removed mdx1 and mdx+csf support. So mdx files may have to be upgraded.

E.g.

  • we had to rename our <name>.stories.mdx files to <name>.mdx (remove the stories.) as storybook removed cfs support in mdx files
  • we had to remove isTemplate from <Meta title="<title>" isTemplate />, as that property was removed

see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#mdx-related-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants