Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angle.normalized() results look wrong #1

Open
pondersome opened this issue Jun 12, 2024 · 0 comments
Open

Angle.normalized() results look wrong #1

pondersome opened this issue Jun 12, 2024 · 0 comments

Comments

@pondersome
Copy link

pondersome commented Jun 12, 2024

Angle.normalized() doesn't correctly map the angle to the supplied normalization range. You can see that in the test code where it reports angles well outside of 0 to TAU. It also changes angles that are already in the normalized range when it shouldn't. Maybe I'm misunderstanding the intended usage...

I can submit a working example as a pull request if you like. With an option for normalizing negative angles back to their positive equivalent

@pondersome pondersome changed the title normalized is broken Angle.normalized() results look wrong Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant