Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picoharp300.py can't load (due to missing interface.slow_counter_interface) [Bug] #100

Open
mario-b-amaro opened this issue Sep 25, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@mario-b-amaro
Copy link

Version

current main

What is affected by the bug?

The module picoharp300.py does not load in qudi v1.2.0

When does the bug occur?

The bugs occur when one tries to load the picoharp300.py module in qudi. It happens right on itialization:

The first error is due to the os library not being imported in picoharp300.py. If one adds the "import os" line to the code, then the most important error appears: the function get_constraints() defined within the PicoHarp300 class does not work. It requires the usage of the SlowCounterConstraints() class, which in previous versions of qudi was defined in slow_counter_interface.py, inside the interface folder This slow_counter_interface.py script seems to be missing from the interface folder in the new qudi versions.

How do we replicate the issue?

  1. Create a config file using the picoharp300.py as the fast counter device
  2. Load this config file on qudi
  3. Try to initialize pulsed_gui

Expected behavior

It should be possible to initialize the picoharp300.py module.

Relevant log output

No response

Additional Comments

No response

Contact Details

mario.bettencourt.amaro@fysik.su.se

@mario-b-amaro mario-b-amaro added the bug Something isn't working label Sep 25, 2023
@timoML
Copy link
Contributor

timoML commented Sep 26, 2023

This piece of hardware is not in much use here in our institute. I assume it got only hastily ported to the new core. We would appreciate if you could invest some time to get it running again and are happy to assist on the way.

As the file is currently not fulfilling the SlowCounterInterface anyway, I would suggest setting up the constraints from
constraints = PulserConstraints()
as specified in the FastCounterInterface::get_constraints(). If the slow counting feature is really needed, some effort would be needed to implement the new DataInStreamInterface that replaced the SlowCounterInterface .

@mario-b-amaro
Copy link
Author

Thank you for the suggestion, I will then try setting the constraints from PulserConstraints() and work from there, as the slow counting feature is not really needed currently.

I will try to get the module running well again, and get back regarding that. I'll get in contact in case any issues arise in the process. Thank you for the availability.

@timoML
Copy link
Contributor

timoML commented Jan 29, 2024

@mario-b-amaro
Did you get the Picoharp hardware to run? There is some interest from others, so a contribution from you would be very valuable to the broader community.

@qku
Copy link
Contributor

qku commented Sep 30, 2024

As the file is currently not fulfilling the SlowCounterInterface anyway, I would suggest setting up the contraints from constraints = PulserConstraints().

Shouldn't the constraints be set up as a dictionary according to FastCounterInterface @timoML ?

@timoML
Copy link
Contributor

timoML commented Sep 30, 2024

Sorry. @qku is absolutely right. Also, the constraints in the FastCounterInterface are poorly documented (#159). We will work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants