Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] use ScalarConstraint for more interfaces #158

Open
qku opened this issue Sep 12, 2024 · 0 comments
Open

[New Feature] use ScalarConstraint for more interfaces #158

qku opened this issue Sep 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@qku
Copy link
Contributor

qku commented Sep 12, 2024

Feature Description

Use qudi.util.constraints.ScalarConstraint in more (if not all) interface-specific hardware constraint classes. It is a great class to use as a building block. It comes with useful features such as type and value checking, clipping and more.

It is not yet used in

  • FiniteSamplingInputConstraints
  • FiniteSamplingIOConstraints
  • and many more

It is already used in

  • DataInStreamConstraints
  • and more

Related Problem

Extra code needs to be written for in-range or type checking of variables against constraints if ScalarConstraint is not used and the interface-specific hardware constraint class does not implement this functionality.

Considered Alternatives

Do nothing: works but requires extra code to be written for each hardware or logic module.

Additional Context

This must not necessarily be a breaking change. It should be possible to implement this in a backwards-compatible way.

Contact Details

No response

@qku qku added the enhancement New feature or request label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant