Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserConfig version mismatches. #2432

Open
kareltucek opened this issue Oct 19, 2024 · 0 comments
Open

UserConfig version mismatches. #2432

kareltucek opened this issue Oct 19, 2024 · 0 comments

Comments

@kareltucek
Copy link
Contributor

2024-10-19-201934_3840x2160_scrot

This isn't exactly true.

What's wrong:

  • The flashed UserConfig is 7.1.0, and as such Agent should load it without complaining.
  • The message mixes firmware's data model version with the present user config's version
  • Firmware's data model version is higher than Agent's user config version, so Agent should also be willing to write UserConfig without complaining.

Requested changes:

  • Explicitly show all three versions in the popup.
  • The message should very clearly distinguish between firmware's data model version and the present user config's version
  • If flashed user config version is <= agent's user config version, it should load the config
  • If Agent's version is lower or equal than firmware's data model version and at the same time the Agent's config version and firmware's data model version major number is either the same, or Agent is at most one version behind, Agent should flash the UserConfig without complaining (at least without complaining too much :-) ).

I propose to use rightModule.firmware.userConfigVersion, rightModule.flashedUserConfigVersion and agent.userConfigVersion to distinguish the three versions.

@mondalaci mondalaci transferred this issue from UltimateHackingKeyboard/agent80 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant