Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nox Theme V0.2 need help #1389

Closed
Jack77777777 opened this issue Feb 7, 2021 · 8 comments
Closed

Nox Theme V0.2 need help #1389

Jack77777777 opened this issue Feb 7, 2021 · 8 comments

Comments

@Jack77777777
Copy link

Jack77777777 commented Feb 7, 2021

Hi,

I copied custom-styles.css from Nox theme folder to /.config/octodash/ and overwrote the existing empty custom-styles.css. I am using a 7" 1024x600 screen.

I have a issue and one question.

Issue:
The input on the loaded file screen is incorrectly arranged
image

Question:
I see no difference at all changing thumbnail from 220x124 to 330x186. Where should i see a difference for a file with 330x186 and the same file with 220x124?

Maybe @noxhirsch @thegarbz @UnchartedBull or someone else can help me.

Thanks in advance of

@noxhirsch
Copy link
Contributor

noxhirsch commented Feb 7, 2021

I'll take a look later today!

Thumbnail size should make the biggest difference in the file details view: https://github.com/UnchartedBull/OctoDash/blob/main/themes/NOX/screenshots/screenshot_file.png
But if it looks good enough for you, you can leave it at 220x124px - it doesn't need to be changed.

@noxhirsch
Copy link
Contributor

I've created a pull request for the fix :)
Here's the fixed CSS: https://github.com/noxhirsch/OctoDash/blob/main/themes/NOX/custom-styles.css

@Jack77777777
Copy link
Author

Great! Will test later Today and report.

@Jack77777777
Copy link
Author

Jack77777777 commented Feb 7, 2021

v0.2.1 fixed it!
And i have to correct me. 330x186 shows bigger and sharper thumnails in detail view and loaded file view.

Thanks for the quick fix.

@Jack77777777
Copy link
Author

@noxhirsch with Beta 3.0.0 there is again something wrong with the alignment
image

@noxhirsch
Copy link
Contributor

Thank you for your notice! I'll take a look as soon as 3.0.0 gets officially released, since I don't have beta installed and it's not a severe problem - just ugly - and everything is still readable ;)

@Jack77777777
Copy link
Author

Cool. I think official relese will be this or next week. For me NOX is the best theme ATM. thanks for your great work!

@thegarbz
Copy link
Collaborator

Just realised @noxhirsch you now have a horizontal progressbar in your 0.21 theme. Kinda makes mine redundant now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants