Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display octoprint errors #1609

Closed
pciavald opened this issue Mar 25, 2021 · 2 comments · Fixed by #2586
Closed

display octoprint errors #1609

pciavald opened this issue Mar 25, 2021 · 2 comments · Fixed by #2586
Labels
enhancement New feature or request
Milestone

Comments

@pciavald
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When octoprint has a connection failure, octodash is not currently prepared to help the user fix the error. Currently:

  • octoprint fails to connect to the printer at boot or the connection fails
  • octodash thinks the printer has been shutdown by the user and goes to sleep mode

Describe the solution you'd like

Octodash should listen for octoprint errors and if an error is detected it should display the error instead of going to sleep mode.

Additional context

We've had several cases of errors and are starting to list them. The last one was appearing in a popup in octoprint, i'm not sure which api endpoint should be used to get that. Any advice ? We can work on this one.

@pciavald pciavald added the enhancement New feature or request label Mar 25, 2021
@UnchartedBull
Copy link
Owner

https://github.com/UnchartedBull/OctoDash/blob/main/src/app/services/socket/socket.octoprint.service.ts#L261 this file to get the data from the OctoPrint Socket (there are way more states available than the few that OctoDash currently has implemented, but the ERROR status is probably the one you're looking for. Just return a different enum value there then and use this service: https://github.com/UnchartedBull/OctoDash/blob/main/src/app/event.service.ts to navigate to a new page.

@pciavald pciavald added this to the v3.1.0 milestone May 3, 2021
@UnchartedBull UnchartedBull modified the milestones: v3.1.0, v2.3.0 Jul 28, 2021
@UnchartedBull
Copy link
Owner

Can be triggered with Virtual Printer with following command:

!!DEBUG:send Error:STOP called because of BLTouch error - restart with M999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants