Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOX theme Layer progess wrong screen position and icon missing #1749

Closed
ipa64 opened this issue May 1, 2021 · 12 comments
Closed

NOX theme Layer progess wrong screen position and icon missing #1749

ipa64 opened this issue May 1, 2021 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@ipa64
Copy link

ipa64 commented May 1, 2021

Hi,
In this case pictures are better than words.

It should be
https://i84.servimg.com/u/f84/20/23/21/77/captur13.png

I get this
https://i84.servimg.com/u/f84/20/23/21/77/img_2810.jpg

Thank you

@ipa64 ipa64 added the bug Something isn't working label May 1, 2021
@ipa64
Copy link
Author

ipa64 commented May 1, 2021

Tested with theGarbz/Focus same behavior
In fact the theme is not applied to the layer progress.

@UnchartedBull
Copy link
Owner

Please add the requested information in the issue template. Otherwise no one can help you.

@pciavald
Copy link
Contributor

pciavald commented May 3, 2021

I'm getting the same issue, NOX theme maintainer knows about it (I can't remember which issue it was in) and is already fixing it. @ipa64 you can fix it yourself before by fiddling with the custom css. Something like this

.height-indication {
  width: auto !important;
  position: fixed !important;
  top: 52vh !important;
  left: 59vw !important;
}

@ipa64
Copy link
Author

ipa64 commented May 4, 2021

I'm getting the same issue, NOX theme maintainer knows about it (I can't remember which issue it was in) and is already fixing it. @ipa64 you can fix it yourself before by fiddling with the custom css. Something like this

.height-indication {
  width: auto !important;
  position: fixed !important;
  top: 52vh !important;
  left: 59vw !important;
}

Thank you pciavald,
I have already tried that without success (and many variants😂), for now my workaraound is to move the line with temperatures a bit higher and the fan line a bit lower.

@thegarbz
Copy link
Collaborator

@ipa64 What screen resolution are you using? You said you had the problem with my focus theme as well, if I can replicate it somehow I'll try and sort it out. But right now I'm unable to see the problem.
Can you also add a screenshot from my theme? It's curious that you're not only loading in the wrong position but you're not loading the icon...

@ipa64
Copy link
Author

ipa64 commented May 15, 2021

@thegarbz, I am using official raspberry touchscreen 7", resolution 800x480.
On my first post you should find 2 print screens, maybe they was made from NOX theme(I forgot), but it’s the same behavior.
Now I am using your focus theme, my workaround was to move a bit higher the temperature line, and move a bit lower the fan line, to make place for the layer progress line.
Here the result: https://i84.servimg.com/u/f84/20/23/21/77/e6db1310.jpg
Thank you

@ipa64
Copy link
Author

ipa64 commented May 16, 2021

@thegarbz , this morning I reinstalled original focus custom-styles.css, and got some screenshots from vnc.
https://i84.servimg.com/u/f84/20/23/21/77/captur14.png
https://i84.servimg.com/u/f84/20/23/21/77/captur15.png

After some comparaison from previous version of octodash, I noticed there is some deep modifications for layer progress in 2.1.2, thru 2.1.1 that was layer-progress from 2.1.2 it's height-progress app.

@thegarbz
Copy link
Collaborator

@ipa64 I'll take a look at it this week. To confirm what versions of everything are you running?
Octodash
Octopi
and while I don't think it's relevant the DisplayLayerProgress plugin as well?

@ipa64
Copy link
Author

ipa64 commented May 17, 2021

@thegarbz
Octoprint 1.6.1
Octodash 2.1.2
Octopi 0.18.0
DisplayLayerProgress 1.26.0
Thank you

@thegarbz
Copy link
Collaborator

thegarbz commented May 17, 2021

@ipa64 for the theGarbz/Focus theme adding the following in the section under PRINTING will display the Layers in the correct place.
I dug through the code today and the recent change is missing a class needed to make the Layer icon appear. I've added a PR for that to be fixed in the next version of Octodash but in the meantime at least this will place the Layer text in the correct place and not overlap it on other elements:

This is from v0.3 of the theme which is currently awaiting approval for inclusion in this repository

app-height-progress .height-indication {
  position: absolute !important;
  top: 60vh;
  left: 68.8vw;
  width: auto !important;
  margin: 0 !important;
  color: var(--dark-text);
  /*visibility: hidden;
  letter-spacing: -1em;*/
}

app-height-progress .height-indication__current-height {
  position: relative;
  top: -0.5vh !important;
  visibility: visible !important;
  font-size: 5vw !important;
  letter-spacing: normal !important;
  color: var(--light-text);
}

@thegarbz
Copy link
Collaborator

thegarbz commented May 20, 2021

@ipa64 both the NOX theme and the Focus theme have been updated. Grab the latest version of whichever you want, and if it's all working you should be able to close this issue now.

@ipa64
Copy link
Author

ipa64 commented May 20, 2021

Now all is working perfectly
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants