-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OctoDash stops print if connected during warmup. #446
Comments
Do you mean it stops the print via OctoPrint? Does this happen on Version 1.4.0? There were some issue with the connection, which were fixed in 1.4.0. |
I'll check again with 1.4.0 tomorrow. |
@UnchartedBull Apologies for taking so long to get back to you on this. Indeed this still occurs in 1.4.0. Also, it occurs if a print is running. For example. Let's say I'm running this print: If I tap the display, the print will stop. This has happened once already when someone was curious about my display. I started the print remotely. It does this because when you ask the Octoprint api to connect, it indeed does connect. A reconnection stops all running jobs. I would say this is the fault of the Octoprint API. This would not be acceptable for the Espurna relay API for example. If you sent a value of |
But this is what the API documents, so it is a fault of OctoDash. The thing is, that with 1.4.0 OctoDash first checks whether a connection is already established and only sends the connect command if there is no connection. Other users reported that this is working and OctoDash isn't issuing a reconnection command if OctoPrint is connected ... Could you please post the reply of |
@UnchartedBull I see. Thanks much for explaining those details. So, I do have the PSUControl option enabled in the OctoDash config. Does that also check for this state before issuing a power on? I'll check these states when I'm in the workshop again in 8~ hours. |
https://github.com/UnchartedBull/OctoDash/blob/master/src/app/standby/standby.component.ts#L36 that is the relevant code bit. PSUControl always get's called to turn the printer on, no matter the current connection state. But as you already said this isn't an issue, since PSUControl does not turn the printer off and on again, if it is already on. I check if PSUControl triggers a connect command as well. |
Will be tracked in #368. My fix doesn't seem to work reliably. Thanks for letting me know! |
If OctoDash is left unconnected and a print is taking place, it will stop the print in progress if a user connects.
What's interesting about this is that shows the layers in progress (Layer 0 of 117) for example.
I am unsure if this only happens if a print is heating up ready for print, but is not currently not really in progress (laying filament down). I can test this scenario later though.
The text was updated successfully, but these errors were encountered: