Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch filtering #2

Open
Glavin001 opened this issue Oct 20, 2018 · 5 comments
Open

Branch filtering #2

Glavin001 opened this issue Oct 20, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed high priority

Comments

@Glavin001
Copy link
Member

From @stevenzeck on October 12, 2018 15:40

Unibeautify CI is great, however if left unchecked it can cause a TON of backlogs in Travis. I forget which repo it was, but Unibeautify was not correct on master. Whenever Renovate created a new branch for a dependency update, Unibeautify CI also created a branch to fix the branch that Renovate created. Scenario example:

  1. master, UB CI is failing and has a unibeautify/master branch to fix it
  2. Renovate creates a branch for typescript dependency update: renovate/typescript3.x. Travis CI build starts for this branch
  3. renovate/typescript3.x also fails UB CI, so UB CI creates a branch to fix it:
    unibeautify/renovate/typescript3.x. Another Travis CI build starts for this branch
  4. Open a PR to merge unibeautify/renovate/typescript3.x to renovate/typescript3.x. Travis CI build starts
  5. Merge PR, another Travis CI build starts for renovate/typescript3.x

That's 4 Travis CI builds when it only needs 1.

Copied from original issue: Unibeautify/unibeautify#205

@Glavin001 Glavin001 self-assigned this Oct 20, 2018
@Glavin001 Glavin001 added enhancement New feature or request help wanted Extra attention is needed high priority labels Oct 20, 2018
@Glavin001
Copy link
Member Author

@stevenzeck Great observation! Do you think disabling branches with glob patterns would be a good solution? For example, exclude renovate/* branch names from being processed.

Also I think this should be moved to https://github.com/Unibeautify/unibeautify-ci-issues
However, it appears https://github-issue-mover.appspot.com is currently down with 503 Server Error.

@Glavin001
Copy link
Member Author

From @lassik on October 17, 2018 13:8

Unibeautify CI is the cloud-based job that prints style errors on Travis, right? It's really cool!

Would it work to only enable it for PRs? If our workflow is that humans only commit via PR, and Renovate only commits changes to package.json

@Glavin001
Copy link
Member Author

Unibeautify CI is the cloud-based job that prints style errors on Travis, right? It's really cool!

No, it is completely separate solution from Travis CI or other CIs. Unibeautify CI creates a branch with fixes, if applicable, and generates a report to show in GitHub Checks tab: https://blog.github.com/2018-05-07-introducing-checks-api/

Check out https://github.com/apps/unibeautify-ci 🎉 !

If our workflow is that humans only commit via PR...

I wonder if I can detect which PRs are opened by humans or not 🤔 .

@Glavin001
Copy link
Member Author

From @stevenzeck on October 17, 2018 17:45

https://docs.travis-ci.com/user/customizing-the-build/#safelisting-or-blocklisting-branches

# blocklist
branches:
  except:
  - /^renovate\/.*$/

@Glavin001
Copy link
Member Author

Good point, @stevenzeck . Learn from the best. Travis CI, tried and true.

@Glavin001 Glavin001 changed the title Evaluate usage of Unibeautify CI Branch filtering Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed high priority
Projects
None yet
Development

No branches or pull requests

1 participant