Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_NCProperties attribute is a fixed length string of size 8192 #300

Closed
shoyer opened this issue Aug 7, 2016 · 3 comments
Closed

_NCProperties attribute is a fixed length string of size 8192 #300

shoyer opened this issue Aug 7, 2016 · 3 comments

Comments

@shoyer
Copy link
Contributor

shoyer commented Aug 7, 2016

$ h5dump empty-4.4.1.nc
HDF5 "empty-4.4.1.nc" {
GROUP "/" {
   ATTRIBUTE "_NCProperties" {
      DATATYPE  H5T_STRING {
         STRSIZE 8192;
         STRPAD H5T_STR_NULLTERM;
         CSET H5T_CSET_UTF8;
         CTYPE H5T_C_S1;
      }
      DATASPACE  SCALAR
      DATA {
      (0): "version=1|netcdflibversion=4.4.1|hdf5libversion=1.8.17"
      }
   }
}
}

vs

$ h5dump empty-4.4.0.nc
HDF5 "empty-4.4.0.nc" {
GROUP "/" {
}
}

This means that an empty netCDF4 file is 8428 bytes with netCDF v4.4.1, versus only 239 bytes with netCDF v4.4.0, which seems like quite a bit more space than necessary.

@DennisHeimbigner DennisHeimbigner self-assigned this Aug 8, 2016
@DennisHeimbigner
Copy link
Collaborator

DennisHeimbigner commented Aug 8, 2016

Fair enough. I will attempt to reduce the space needed in the file.

@WardF
Copy link
Member

WardF commented Aug 17, 2016

The pull request appears to be in order; merging shortly.

@WardF WardF closed this as completed Aug 17, 2016
@WardF WardF reopened this Aug 17, 2016
@WardF
Copy link
Member

WardF commented Aug 17, 2016

Closed prematurely; need Windows test to finish then will close.

@WardF WardF closed this as completed Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants