You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
python3.6/site-packages/siphon/ncss.py:433: VisibleDeprecationWarning: Reading unicode strings without specifying the encoding argument is deprecated. Set the encoding, use None for the system default.
converters={'date': lambda s: parse_iso_date(s.decode('utf-8'))})
For some reason, our existing tests don't trigger this warning. The warning occurs because numpy 1.14 started being more pedantic about the encoding stuff, and adding an encoding keyword. We can make things work fine by passing this kwarg with a value of 'utf-8', but of course that means we only work on numpy 1.14. Switching to StringIO instead of BytesIO does not solve the issue. Options I can think of:
Bump numpy requirement to 1.14
Add our own wrapper/helper for genfromtxt that is a straight passthru on numpy > 1.14, and drops the encoding kwarg otherwise
Add a warning filter to swallow the deprecation warning, bump numpy to 1.14 much later.
The text was updated successfully, but these errors were encountered:
So this code:
produces the warning:
For some reason, our existing tests don't trigger this warning. The warning occurs because numpy 1.14 started being more pedantic about the encoding stuff, and adding an
encoding
keyword. We can make things work fine by passing this kwarg with a value of'utf-8'
, but of course that means we only work on numpy 1.14. Switching toStringIO
instead ofBytesIO
does not solve the issue. Options I can think of:genfromtxt
that is a straight passthru on numpy > 1.14, and drops theencoding
kwarg otherwiseThe text was updated successfully, but these errors were encountered: