-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BDInfo does not create report #35
Comments
I created an ISO with tsMuxwer, add a colon in disk label and work ok. What is the duration of your test file? |
I tested with UHD. It was 60 GB I guess. |
I also tried to generate the iso with tsMuxwer. But also for that iso no report is created. |
|
Not sure whether we understand each other correctly. I created two iso for testing. The 1st one is small. The second one the whole film They have the same problem with bitrate of 0 - fitting to your link. |
Ok. Yes the problem is the invalid characters. I found other 2 bug. The first is, BDInfo contain an exception code for this but never enter and the second is an invalid cross tread operation that happened few times. I fixed the exception and the invalid characters. I upload a fixed version letter. |
Hi guys, just ran few tests with both ISO images. Hower, the files seem not to be fully BluRay compliant, because the headers for both AVC and MPEG2 streams are not detected as such in the MPEG Transport stream, and therefore the stream parsing code is not executed at all. The stream infos listed in the list are only read from the playlists / clipinfo files. Ran a reencode with handbrake and remuxed with TSmuxeR, both images are detected without any problem, regardless of the UDF label. Image 1 Initial Scan The MPEG TS parsing was written by the original author back in 2011 and only modified to support ISO images by me. It still may contain bugs, however none of commercially mastered BluRay discs I came across until now had this problem. Will have a closer look at the code, but it has a very low priority for now. If someone wants to submit a patch, you are very welcome to do so. |
Ok, there were a few things wrong with those images, that I actually missed the report autosaving problem. However, I have it fixed with a571337 |
Thanks UniqProject. I fixed the label with this but your method is better because only remove invalid characters. public static string RemoveSpecialCharacters(string str)
string reportName = string.Format( CultureInfo.InvariantCulture, You can try to change: reportName = ToolBox.GetSafeFileName(reportName); for |
I change this "Exception" in FormMain.cs because never used. private void GenerateReportCompleted(object sender, RunWorkerCompletedEventArgs e)
|
Please try the latest beta release v0.7.6.0b and see if problem is fixed. |
It seems to work and scanning is 15-30% faster (compared to 0.7.5.8b). But: While comparing the reports I saw that there were also some correct changes for chapters. |
I haven't come across such a disk so far, so unfortunately can't tell what the problem is. As for the rest, can you please test with the latest beta release v0.7.6.1b and see if this has fixed anything? |
No problems so far. Looks good. |
One small thing - can you format the bitrate of the video? You do it already for the audio and subtitles: `Codec Bitrate Description MPEG-H HEVC Video 30,311 kbps 2160p / 23.976 fps / 16:9 / Main 10 @ Level 5.1 @ High / 10 bits / HDR10 / BT.2020
AUDIO: Codec Language Bitrate Description DTS:X Master Audio English 6679 kbps 7.1 / 48 kHz / 6679 kbps / 24-bit (DTS Core: 5.1 / 48 kHz / 1509 kbps / 24-bit) The kbps for audio is in one columnn - but not the one for the video |
Not sure whether I was clear what I meant
to
|
BDInfo does not create a report (does not save and does not show it) when the disc label contains a characters which cannot be written.
This problem appears of course only when I open ISO-images.
Example:
Create an ISO with ImgBurn and add as Volume Label (UDF) 'Test: 1'
The disc label contains a colon and cannot be used as filename.
BDInfo will read the ISO but won't create a report.
You have to replace such characters by '-' or ' ' or eliminate them.
The text was updated successfully, but these errors were encountered: