Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data.Lens._Newtype is compiling incorrectly #28

Open
Renegatto opened this issue Aug 16, 2024 · 2 comments
Open

Data.Lens._Newtype is compiling incorrectly #28

Renegatto opened this issue Aug 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Renegatto
Copy link

The usage of Data.Lens._Newtype includes _Newtype in the output, but it compiles incorrectly into:

M.MyModule__Newtype = M.Data_Profunctor_dimap(dictProfunctor)(M.Safe_Coerce_coerce())

where dictProfunctor is undefined in the output lua module.
I suppose it should have compiled into something like

M.MyModule__Newtype = function (dictProfunctor)
  return M.Data_Profunctor_dimap(dictProfunctor)(M.Safe_Coerce_coerce())
end
@Renegatto Renegatto changed the title Data.Lens._Newtype is compiling incorrectly Data.Lens._Newtype is compiling incorrectly Aug 16, 2024
@Renegatto
Copy link
Author

Most likely it was cc32d90 that has been fixed in develop, I will check.

@Unisay Unisay self-assigned this Aug 29, 2024
@Unisay Unisay added the bug Something isn't working label Aug 29, 2024
@Unisay
Copy link
Owner

Unisay commented Sep 10, 2024

I have backported the bugix, please test and close the issue if you confirm that bug has gone. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants