Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info Search box does not search checksummed addresses #429

Open
Rachel-Eichenberger opened this issue Feb 2, 2022 · 1 comment
Open

Comments

@Rachel-Eichenberger
Copy link

Rachel-Eichenberger commented Feb 2, 2022

Bug Description
Info Search box does not search checksummed addresses, and will not pull up token.

Steps to Reproduce

Go to info.uniswap.org
Enter checksummed address in search box
Happens in V2 and V3 info (Uniswap/v3-info#152)

Expected Behavior
to search with either checksummed or lowercase and find the token

@Rachel-Eichenberger
Copy link
Author

Rachel-Eichenberger commented Mar 9, 2022

Think I have a working solution, I thought I had it when I opened this, but realized I missed a test scenario

using
value ? value.slice(0, 2) === "0x" ? value.toLowerCase() : value.toUpperCase() : '',

in lines 190 and 191 gives the ability to use checksummed addresses or symbol/name
I have it coded and tested, I didn't want to make a Pull request without someone checking it
https://github.com/Rachel-Eichenberger/info/blob/v2/src/components/Search/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant