Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add useGasEstimate hook to proactively disable buttons + show errors #872

Closed
NoahZinsmeister opened this issue Jun 5, 2020 · 2 comments
Closed

add useGasEstimate hook to proactively disable buttons + show errors #872

NoahZinsmeister opened this issue Jun 5, 2020 · 2 comments
Assignees
@moodysalem

Comments

@NoahZinsmeister
Copy link
Contributor

No description provided.

@NoahZinsmeister NoahZinsmeister self-assigned this Jun 5, 2020
@NoahZinsmeister NoahZinsmeister mentioned this issue Jun 5, 2020
Merged
@moodysalem moodysalem mentioned this issue Jul 30, 2020
Closed
@moodysalem
Copy link
Contributor

tried this UI, but it's not that good because of inconsistencies between infura nodes + inconsistency between UI data and infura node data, which can result in failures where not valid.

instead we should surface useful error messages when we can't estimate gas at confirm swap time. going to do this by using eth_call and translating revert reasons

@moodysalem
Copy link
Contributor

closed in favor of #871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moodysalem moodysalem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NoahZinsmeister @moodysalem