Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

“You are the first liquidity provider...” message flashes when navigating directly to Add Liquidity page #842

Closed
danrobinson opened this issue May 29, 2020 · 1 comment
Closed

“You are the first liquidity provider...” message flashes when navigating directly to Add Liquidity page #842

danrobinson opened this issue May 29, 2020 · 1 comment
Assignees
@moodysalem
Labels
bug Something isn't working

Comments

@danrobinson
Copy link

Bug Description
When navigating directly to an Add Liquidity page via the URL, the “You are the first liquidity provider” message flashes for a moment, even if there is already liquidity in the pair.

Steps to Reproduce

  1. Go to https://uniswap.exchange/add/0x6b175474e89094c44da98b954eedeac495271d0f-0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2. (It lasts longer when the internet connection is slow.)
    ...

Expected Behavior
No message flashed.
@danrobinson danrobinson added the bug Something isn't working label May 29, 2020
@moodysalem moodysalem self-assigned this May 29, 2020
@moodysalem
Copy link
Contributor

I caused this because we don't accurately detect the loading state in the new usePair

moodysalem added a commit that referenced this issue May 29, 2020
@moodysalem
fix(multicall): return loading states from the multicall hooks #842
d4011f7
crisog pushed a commit to Levinswap/levinswap-interface that referenced this issue Feb 5, 2021
@moodysalem
fix(multicall): return loading states from the multicall hooks Uniswa…
ade0a91 
…p#842
daniel-dev1990 pushed a commit to daniel-dev1990/uniswap-interface that referenced this issue Jul 8, 2021
@moodysalem
fix(multicall): return loading states from the multicall hooks Uniswa…
49acebc 
…p#842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moodysalem moodysalem

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danrobinson @moodysalem