Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add right margin to mobile token list update notification lists #1142

Merged

Conversation

JFrankfurt
Copy link
Contributor

fixes #1140

@vercel
Copy link

vercel bot commented Oct 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uniswap/uniswap-interface/rkshavsnc
✅ Preview: https://uniswap-interfa-git-fork-jfrankfurt-fix-token-list-mobil-0dc314.uniswap.vercel.app

@moodysalem
Copy link
Contributor

Are you already able to horizontally scroll? Is there risk in your pr of not seeing the next notification?

@JFrankfurt
Copy link
Contributor Author

Horizontal scroll functions already, though there's no visual affordance for it. The 35px offset is the same as the internal padding on these cards and it does allow enough space to see the next one on the screens I tested. (Pixel 3, Samsung something or other). Shoulda included a screenshot of the fix, but I'd already nuked my test data and was heading to bed.

@moodysalem moodysalem merged commit c45c293 into Uniswap:master Oct 1, 2020
@JFrankfurt
Copy link
Contributor Author

before
image

after
image

@JFrankfurt
Copy link
Contributor Author

I just tested w/ a few smaller devices and I'd actually in retrospect put this at a 20px margin instead, but it's better regardless. On the Moto G4 (not wide at all, only 360px) you almost can't see that there's a second.

@JFrankfurt
Copy link
Contributor Author

@moodysalem see #1146

crisog pushed a commit to Levinswap/levinswap-interface that referenced this pull request Feb 5, 2021
daniel-dev1990 pushed a commit to daniel-dev1990/uniswap-interface that referenced this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple token list updates look smushed on mobile
2 participants