feat(i18n): save and load locale from redux store #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 26, 2021 18:39
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/uniswap/uniswap-interface/Gc9nfRZTXU8NBbRJkMb1BZ4d72sJ |
moodysalem
suggested changes
May 27, 2021
moodysalem
suggested changes
May 28, 2021
moodysalem
suggested changes
May 28, 2021
moodysalem
suggested changes
May 28, 2021
moodysalem
approved these changes
May 28, 2021
src/i18n.tsx
Outdated
| const [language, region] = navigator.language.split('-') | ||
|
|
||
| if (region) { | ||
| return parseLocale(`${language}-${region}`) ?? parseLocale(language) |
There was a problem hiding this comment.
region.toUpperCase()
Note that in Safari on iOS prior to 10.2, the country code returned is lowercase: "en-us", "fr-fr" etc.
https://developer.mozilla.org/en-US/docs/Web/API/NavigatorLanguage/language
daniel-dev1990
pushed a commit
to daniel-dev1990/uniswap-interface
that referenced
this pull request
Jul 8, 2021
* wrap sock around function component to get re-renders * removed sourcelocale since we are using custom ids * load locale data dynamically * undo dev change * ran yarn i18n:extract * store locale in redux * added support for redux * restored header * refactor * addressed pr feedback * specify type * added navigator locale fallback to generic dialect * make locale array const and typed * addressed pr feedback * fixed various * addressed pr feedback * make supported locales constant uppercase * add back toUpperCase removed during refactoring * removed lingui/detect-locale * run yarn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.