Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flipping zeroForOne before fee indices assignment in Pool.swap doesn't cause the tests to fail #606

Open
shuhuiluo opened this issue Apr 24, 2024 · 0 comments
Labels

Comments

@shuhuiluo
Copy link
Contributor

Component

Pool Actions (swap, modifyLiquidity, donate, take, settle, mint)

Describe the suggested feature and problem it solves.

if (!zeroForOne) {
feeGrowthGlobal0X128 = self.feeGrowthGlobal0X128;
feeGrowthGlobal1X128 = state.feeGrowthGlobalX128;
} else {
feeGrowthGlobal0X128 = state.feeGrowthGlobalX128;
feeGrowthGlobal1X128 = self.feeGrowthGlobal1X128;
}

It may be wise to add assertions on the fee indices.

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant