Skip to content

Commit ea500e8

Browse files
author
Dmytro Ivanov
committed
API validator fixes
1 parent 219e951 commit ea500e8

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

Diff for: Assets/Tests/InputSystem/APIVerificationTests.cs

+4
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,10 @@ public class SwitchProControllerHID : UnityEngine.InputSystem.Gamepad
424424
[Property("Exclusions", @"1.0.0
425425
public class DualShock4GamepadHID : UnityEngine.InputSystem.DualShock.DualShockGamepad
426426
")]
427+
// IMECompositionEvent.compositionString changed from field to property due to hard-to-avoid changes to IMECompositionString struct.
428+
[Property("Exclusions", @"1.0.0
429+
public struct IMECompositionEvent : UnityEngine.InputSystem.LowLevel.IInputEventTypeInfo
430+
")]
427431
public void API_MinorVersionsHaveNoBreakingChanges()
428432
{
429433
var currentVersion = CoreTests.PackageJson.ReadVersion();

Diff for: Packages/com.unity.inputsystem/InputSystem/Events/IMECompositionEvent.cs

+6-1
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,14 @@
66
using Unity.Collections.LowLevel.Unsafe;
77
using UnityEngine.InputSystem.Utilities;
88

9+
//// TODO for v2 remove and replace with just string.
10+
911
namespace UnityEngine.InputSystem.LowLevel
1012
{
13+
/// <summary>
14+
/// Deprecated variant of IME composition event. Please use <see cref="IMECompositionEventVariableSize"/> for replacement.
15+
/// </summary>
16+
/// <see cref="IMECompositionEventVariableSize"/>
1117
[Obsolete("IMECompositionEvent is obsolete, please use IMECompositionEventVariableSize")]
1218
[StructLayout(LayoutKind.Explicit, Size = InputEvent.kBaseEventSize + sizeof(int) + (sizeof(char) * kIMECharBufferSize))]
1319
public unsafe struct IMECompositionEvent : IInputEventTypeInfo
@@ -108,7 +114,6 @@ public static unsafe void QueueEvent(int deviceId, string str, double time)
108114
}
109115
}
110116

111-
//// TODO for v2 remove and replace with just string.
112117
/// <summary>
113118
/// A struct representing an string of characters generated by an IME for text input.
114119
/// </summary>

0 commit comments

Comments
 (0)