replace enable_shutdown_msg with enable_error_to_user

Author: simonLeary42

defaults/config.ini.default

@@ -15,7 +15,7 @@ terms_of_service_url = "https://github.com" ; this can be external or a portal p
 account_policy_url = "https://github.com" ; this can be external or a portal page created with "content management"
 allow_die = true ; internal use only
 enable_verbose_error_log = true ; internal use only
-enable_shutdown_msg = true ; internal use only
+enable_error_to_user = true ; internal use only
 
 [ldap]
 uri = "ldap://identity"  ; URI of remote LDAP server

deployment/overrides/phpunit/config/config.ini

@@ -5,3 +5,4 @@ custom_user_mappings_dir = "test/custom_user_mappings"
 allow_die = false
 enable_verbose_error_log = false
 enable_shutdown_message = false
+enable_error_to_user = false

deployment/overrides/worker/config/config.ini

@@ -1,2 +1,2 @@
 [site]
-enable_shutdown_msg = false
+enable_error_to_user = false

resources/lib/UnitySite.php

@@ -47,6 +47,9 @@ private static function errorToUser(
         int $http_response_code,
         string|null $errorid = null
     ) {
+        if (CONFIG["site"]["enable_error_to_user"] == false) {
+            return;
+        }
         // TODO uncomment after upgrade to php 8.4
         // http_clear_last_response_headers();
         if (!headers_sent()) {
@@ -119,9 +122,6 @@ public static function internalServerError($message, $error = null, $data = null
     // https://www.php.net/manual/en/function.register-shutdown-function.php
     public static function shutdown()
     {
-        if (CONFIG["site"]["enable_shutdown_msg"] == false) {
-            return;
-        }
         $e = error_get_last();
         if (is_null($e) || $e["type"] !== E_ERROR) {
             return;