Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm values for health checks not configurable in unleash-edge #96

Closed
I3uckwheat opened this issue Oct 17, 2023 · 2 comments · Fixed by #97
Closed

helm values for health checks not configurable in unleash-edge #96

I3uckwheat opened this issue Oct 17, 2023 · 2 comments · Fixed by #97
Labels
enhancement New feature or request

Comments

@I3uckwheat
Copy link
Contributor

I3uckwheat commented Oct 17, 2023

Describe the feature request

I want to be able to edit the helm values for the livenessProbe and redinessProbe urls.

Background

Currently the environment variable for the BASE_PATH will allow overwriting of the base path for unleash-edge. This can cause a situation where your health checks are actually at /BASE_PATH/internal-backstage/health and you cannot deploy using the provided helm chart for unleash-edge. In unleash itself, it allows for changing the base path, as well as changing the health-check paths to allow for a base path change.

Solution suggestions

  1. Update the deployment.yaml file to allow for configuration in the values.yaml file for the livenessProbe and redinessProbe values, much like unleash's helm charts
  2. Update the deployment.yaml file to use the readiness command outlined in the documentation here
    1. This may require an update to the utility that is called to utilize the BASE_PATH environment variable

PR for the first solution: #97

@I3uckwheat
Copy link
Contributor Author

This is actively blocking our use of Unleash as we have to use a subroute for this with our current ecosystem and a subdomain is not really an easy option.

@bcampbellGG
Copy link

We ran into the same issue trying to host unleash-edge with a custom base path, we ended up just forking the chart to modify the .yaml file, this would be a useful addition to have though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants