Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When shutting down Edge, we should persist metrics upstream. #294

Closed
chriswk opened this issue Oct 5, 2023 · 2 comments
Closed

When shutting down Edge, we should persist metrics upstream. #294

chriswk opened this issue Oct 5, 2023 · 2 comments
Assignees
@chriswk
Labels
enhancement New feature or request

Comments

@chriswk
Copy link
Contributor

chriswk commented Oct 5, 2023

Describe the feature request

I would like Edge to persist metrics upstream on shutdown.

Background

Currently, if Edge has persistence configured, we do already persist tokens/features to the configured persistence when shutting down. We should also make one last attempt to upload metrics to upstream when shutting down.

Solution suggestions

No response
@chriswk chriswk added the enhancement New feature or request label Oct 5, 2023
@chriswk chriswk self-assigned this Oct 5, 2023
@ivarconr
Copy link
Member

Yes, flushing cached metrics would be preferred on shutdown. This is in line with how node SDK (and thus the proxy) do it today.

@sighphyre
Copy link
Member

Closed by #564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chriswk chriswk

Labels
enhancement New feature or request
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ivarconr @chriswk @sighphyre