Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Normalize the stack #1

Open
6 of 8 tasks
elhoyos opened this issue Feb 10, 2019 · 2 comments
Open
6 of 8 tasks

Normalize the stack #1

elhoyos opened this issue Feb 10, 2019 · 2 comments
Assignees

Comments

@elhoyos
Copy link
Collaborator

elhoyos commented Feb 10, 2019

With the intention to increase the support of this project under the Unleash organization, it would be desirable to make it follow the same stack of unleash-client-node.

I'm opening this issue to build a consensus on what would be the scope of that stack. I will start with a briefing of the current situation and then I will include possible changes.

unleash-express is an express.js middleware that keeps the results of all calls to isEnabled and experiment (later on this) in-sync with a browser cookie.

It depends on a forked version of unleash-client-node that implements variants via client.experiment and is incompatible with our latest upstream variant version (Unleash/unleash#379).

Tests are implemented with ava and supertest. So that part is similar to what we have in unleash and unleash-client-node.

Proposed changes:

  • Conform to Apache license 2.0
  • rewire npm
  • eslint
  • editorconfig
  • Dependencies upgrades
  • Code Climate integration
  • Travis-CI integration
  • Conform to upstream variants of unleash-client-node

Nice to have:

  • TypeScript

Thank you for embracing this common effort.

@nathanredblur
Copy link

Unleash should have a way to get to export the cars by an api to allow work with single aplicaciones like react or angular.

@dmaevac
Copy link

dmaevac commented Feb 15, 2019

These seem like very sensible ideas, I dont believe they need much discussion. Normalizing the stack benefits everyone working in the unleash ecosystem.

@elhoyos elhoyos self-assigned this Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants