You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
With the intention to increase the support of this project under the Unleash organization, it would be desirable to make it follow the same stack of unleash-client-node.
I'm opening this issue to build a consensus on what would be the scope of that stack. I will start with a briefing of the current situation and then I will include possible changes.
unleash-express is an express.js middleware that keeps the results of all calls to isEnabled and experiment (later on this) in-sync with a browser cookie.
It depends on a forked version of unleash-client-node that implements variants via client.experiment and is incompatible with our latest upstream variant version (Unleash/unleash#379).
Tests are implemented with ava and supertest. So that part is similar to what we have in unleash and unleash-client-node.
Proposed changes:
Conform to Apache license 2.0
rewire npm
eslint
editorconfig
Dependencies upgrades
Code Climate integration
Travis-CI integration
Conform to upstream variants of unleash-client-node
Nice to have:
TypeScript
Thank you for embracing this common effort.
The text was updated successfully, but these errors were encountered:
These seem like very sensible ideas, I dont believe they need much discussion. Normalizing the stack benefits everyone working in the unleash ecosystem.
With the intention to increase the support of this project under the Unleash organization, it would be desirable to make it follow the same stack of unleash-client-node.
I'm opening this issue to build a consensus on what would be the scope of that stack. I will start with a briefing of the current situation and then I will include possible changes.
unleash-express is an express.js middleware that keeps the results of all calls to
isEnabled
andexperiment
(later on this) in-sync with a browser cookie.It depends on a forked version of unleash-client-node that implements variants via
client.experiment
and is incompatible with our latest upstream variant version (Unleash/unleash#379).Tests are implemented with
ava
andsupertest
. So that part is similar to what we have in unleash and unleash-client-node.Proposed changes:
Nice to have:
Thank you for embracing this common effort.
The text was updated successfully, but these errors were encountered: