Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash GHA when Vercel domain aliasing fails #178

Closed
Vadorequest opened this issue Oct 17, 2020 · 1 comment
Closed

Do not crash GHA when Vercel domain aliasing fails #178

Vadorequest opened this issue Oct 17, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Vadorequest
Copy link
Member

Currently, if the Vercel aliasing fails during Github Action, the whole build is aborted.

It's not how it should work, aliasing my fail for various reasons and that shouldn't stop a team from working properly. It'd be fine not to have the alias but still continue the build, and run E2E/LH tests.

Also, it makes believe the deployment has failed, but it's not true. When aliasing fails, only the alias fails, Vercel did deploy correctly, though.

npx now alias $ZEIT_DEPLOYMENT_URL $ZEIT_DEPLOYMENT_ALIAS --token $ZEIT_TOKEN

Therefore, there is nothing stopping us from considering the aliasing part as optional, and take mesure from stopping the whole build when it fails.

@Vadorequest Vadorequest added enhancement New feature or request good first issue Good for newcomers labels Oct 17, 2020
@Vadorequest
Copy link
Member Author

Vadorequest commented Oct 18, 2020

Builds will no longer crash when Vercel aliasing fails. See #180

Next step is to change the github comment when the aliasing fails, I tried a few things but wasn't able to do it. (not familiar enough with bash)

@Demmonius FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant