-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSX files needs to have a React import #204
Comments
Yeah, there is some issues about this that aren't directly related to NRN. See vercel/next.js#18096 (comment) I didn't spot this, though (or, did I fix it on my private fork but forgot to fix it in NRN? 🤔 ). I believe you can remove that particular rule from your project ( Stuff to do with Babel, TypeScript and other complicated stuff. As long as it compiles fine, the eslint rule can be removed. |
Isn't better keep the rule and import React consistently just like the rest of the project? |
Not if it's not necessary. It was only done before because it was a requirement, but it's not the case anymore. Also, code linters always complained about React being imported yet unused. |
ok. |
A few files are not importing React, the one I noticed was:
MultiversalGlobalStyles
More info: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/react-in-jsx-scope.md
Again, after last pull.
The text was updated successfully, but these errors were encountered: