Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated LightHouse reporting as PR comment (Github actions CI) #78

Closed
Vadorequest opened this issue May 31, 2020 · 2 comments · Fixed by #103
Closed

Automated LightHouse reporting as PR comment (Github actions CI) #78

Vadorequest opened this issue May 31, 2020 · 2 comments · Fixed by #103
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Vadorequest
Copy link
Member

Goal

Run a lighthouse report when a commit is pushed, which eventually displays the lighthouse results as a PR comment.

foo-software/lighthouse-check-action#24

This could run in parallel with E2E (or afterwards, I'm not sure if parallel github actions are possible)
@Vadorequest Vadorequest added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 31, 2020
@Vadorequest
Copy link
Member Author

@Demmonius I'd love your contribution on this! 😉

@Demmonius Demmonius linked a pull request Jun 10, 2020 that will close this issue
CI - Automatically run LightHouse (on PR commits) #103
Merged
@Vadorequest
Copy link
Member Author

This has been implemented and is now available.

The first implementation had changed the Github Action trigger from push to pull_request, which created a few regression. We eventually rolled back to push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI - Automatically run LightHouse (on PR commits) UnlyEd/next-right-now
1 participant
@Vadorequest