Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI: Add the ability to specify the start/end date for role assignment #52

Closed
1 of 4 tasks
WillStrohl opened this issue Aug 8, 2023 · 0 comments · Fixed by #90
Closed
1 of 4 tasks

SI: Add the ability to specify the start/end date for role assignment #52

WillStrohl opened this issue Aug 8, 2023 · 0 comments · Fixed by #90
Labels
enhancement New feature or request
Milestone

Comments

@WillStrohl
Copy link
Contributor

Sponsorship

If this request requires additional support (e.g., such as direct email/phone/meeting/development), I have the following interest in helping to sponsor the effot via GitHub Sponsors:

  • None, please continute to work for me for free :P
  • Absolutely, I get value out of this!
  • Maybe later
  • I'm already a sponsor... Woot!

Is your feature request related to a problem?

When adding/removing from a role, right now you can simply add/remove the person from a role in a single click. This is super-useful, but there's a very common optional use case of also assigning the start/end date of the role.

Describe the solution you'd like

The existing add/remove can stay and be used as-is, in most situations. A new icon should be added next to the add/remove icon, that appears to be a calendar. When clicked, it shows a Start Date and End Date.

  • These should correspond with the start and expiration fields in the role itself.
  • The start date should always be before the end date, by at least 1 calendar day.
  • When saved, these values are saved to the role record appropriately, allowing for these selected dates to be used as expected.
  • If this is an update (there are dates assigned already), there needs to be an option to clear the dates. Doing this will delete the dates, update the role, and return the view to the original state, only updated, if necessary.

There are new usability issues that will need to be addressed:

  • If there are any dates assigned to the role, the add/remove icon will initiate a confirmation dialog, stating, "This role has a start date and/or end date assigned to it. Clicking OK will clear those values. This action CANNOT be undone. Do you want to proceed?"
  • Clicking Cancel will cancel everything and no changes will be applied.
  • Clicking Ok will clear the dates from the role and perform the appropriate add/remove action.
  • If the dates are cleared in this way, a second log should be added to state as much. RoleName was removed from Username (##) by Username (##).

Describe alternatives you've considered

N/A

Additional context

N/A

@WillStrohl WillStrohl added the enhancement New feature or request label Aug 8, 2023
@WillStrohl WillStrohl added this to the 01.00.01 milestone Aug 8, 2023
@WillStrohl WillStrohl modified the milestones: 01.01.01, 01.02.00 Aug 30, 2023
@WillStrohl WillStrohl changed the title Add the ability to specify the start/end date for role assignment SI: Add the ability to specify the start/end date for role assignment Mar 26, 2024
@WillStrohl WillStrohl mentioned this issue May 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant