Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name in wally.toml doesn't match name in project.json #14

Closed
magnalite opened this issue Aug 4, 2021 · 1 comment · Fixed by #25
Closed

Package name in wally.toml doesn't match name in project.json #14

magnalite opened this issue Aug 4, 2021 · 1 comment · Fixed by #25
Labels
bug Something isn't working

Comments

@magnalite
Copy link
Contributor

Currently when we write packages to the Packages folder we write a script to be required along with the package. This script then finds the package in the _Index folder. It does this indexing based upon the name in the wally.toml. However when these folders are synced by rojo they get renamed to whatever is set in the project.json! This means the script we originally require can no longer find the package correctly!

As an example we can look at this Roact package

image
We can see it is roblox_roact@1.4.0/Roact as it has been renamed by rojo but the script we require will look for roblox_roact@1.4.0/roact as this is the name specified in the wally.toml. As a result we cannot require Roact.

@LPGhatguy LPGhatguy added the bug Something isn't working label Aug 4, 2021
@LPGhatguy
Copy link
Contributor

We should fix this in the packages we've deployed so far, but I'm inclined to call this a Rojo bug. The name of the module should match the folder, not the name field in the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants