reserved identifier violation

[elfring]

I would like to point out that identifiers like "HAMMER_ALLOCATOR__H__" and "mm__" do eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

[uucidl]

I looked up the reference for that and found:
http://en.cppreference.com/w/cpp/language/identifiers#In_declarations

In declarations
An identifier can be used to name objects, references, functions, enumerators, types, class members, namespaces, templates, template specializations, parameter packs, goto labels, and other entities, with the following exceptions:
the identifiers that are keywords cannot be used for other purposes;
the identifiers with a double underscore anywhere are reserved;
the identifiers that begin with an underscore followed by an uppercase letter are reserved;
the identifiers that begin with an underscore are reserved in the global namespace.
"Reserved" here means that the standard library headers #define or declare such identifiers for their internal needs, the compiler may predefine non-standard identifiers of that kind, and that name mangling algorithm may assume that some of these identifiers are not in use. If the programmer uses such identifiers, the behavior is undefined.
In addition, it's undefined behavior to #define or #undef names identical to keywords. If at least one standard library header is included, it's undefined behavior to #define or #undef identifiers identical to names declared in any standard library header.

[pesco]

Do we know any platforms where this causes a problem?

[elfring]

How do you think about to avoid that this software depends on undefined behaviour?

[pesco]

Would you like to submit a pull request?