Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 13: this.paginationService.defaultId is a function #215

Open
thoni56 opened this issue Mar 14, 2017 · 1 comment
Open

Step 13: this.paginationService.defaultId is a function #215

thoni56 opened this issue Mar 14, 2017 · 1 comment

Comments

@thoni56
Copy link

thoni56 commented Mar 14, 2017

The changes introduced in step 13, (13.8, 13.9 and 13.16, to implement pagination uses paginationService from ng2-pagination which seems to have changed its API so that the defaultId is now a function.

(Don't know how to provide a useful PR that can be applied in the midst of a history, would that be included by starting a new branch from the earliest change and then rebase the rest of the steps/changes onto it, maybe? And repeating the process for all subsequent changes...)

@aleksander351
Copy link

Like it was mentioned, it is just a typo in the tutorial.
Just put the brackets at the end like so: this.paginationService.defaultId()
And mark the issue as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants