Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an option to specify Xpress calls #1139

Closed
simonfernandes opened this issue Jul 31, 2024 · 3 comments
Closed

Create an option to specify Xpress calls #1139

simonfernandes opened this issue Jul 31, 2024 · 3 comments
Assignees
Labels
area: uop/stfc/submissions An issue being handled by the STFC submissions team area: uop/stfc An issue relating to the STFC user office project.

Comments

@simonfernandes
Copy link
Contributor

We need an option when setting up a call that will specify proposals in the call should be managed a different way (via the new Xpress management page).

Details need finalising but so far we have discussed having a simple checkbox. We need to consider whether the checkbox itself should be hidden behind a feature flag (i.e. not visible to other facilities). This may change how we word the option (e.g. "Xpress" vs something more generic).

@simonfernandes simonfernandes added area: uop/stfc An issue relating to the STFC user office project. area: uop/stfc/submissions An issue being handled by the STFC submissions team labels Jul 31, 2024
@bashanlam bashanlam self-assigned this Aug 9, 2024
@bashanlam
Copy link

bashanlam commented Aug 21, 2024

@simonfernandes @deepaksftc @srconway @bolmsten @martin-trajanovski My proposed changes to address this issue are as follows. Any comment?

  1. Add new column route to call table to identify "Xpress" proposal
  2. Modify the 'Create new call' and 'Update the call' pages to accommodate the new column. The fields displayed on these pages for the new column should be conditional based on whether the Xpress feature flag (FeatureId.STFC_XPRESS_MANAGEMENT) is enabled

@srconway
Copy link

Sounds good to me. As I mentioned I think it would make sense to give the column a generic name - "Route"? where we add 'Xpress' as the data rather than an Xpress boolean column. Not sure if that's what you were planning anyway.

@simonfernandes
Copy link
Contributor Author

Sprint planning notes:

Per Fredrik's suggestion to detect an Xpress proposal through its workflow, we will need to consider the workflow as part of this in #1109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: uop/stfc/submissions An issue being handled by the STFC submissions team area: uop/stfc An issue relating to the STFC user office project.
Projects
None yet
Development

No branches or pull requests

3 participants