Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to view proposal on Xpress management page #1205

Closed
simonfernandes opened this issue Oct 25, 2024 · 3 comments
Closed

Add button to view proposal on Xpress management page #1205

simonfernandes opened this issue Oct 25, 2024 · 3 comments
Assignees
Labels
area: uop/stfc/submissions An issue being handled by the STFC submissions team area: uop/stfc An issue relating to the STFC user office project.

Comments

@simonfernandes
Copy link
Contributor

We are missing a "View proposal" button on each row of the Xpress management page. It should show the same information that is usually shown when clicking the button for a non-xpress proposal, but should include any extra, relevant Xpress information (technique, instrument, etc.).

In the modal pop up, we should also see if it's feasible to remove the review tabs which are not applicable to Xpress.

Originated from a call with Emma, Deepak and Simon on 25/10/2024.


image

image

@simonfernandes simonfernandes added area: uop/stfc An issue relating to the STFC user office project. area: uop/stfc/submissions An issue being handled by the STFC submissions team labels Oct 25, 2024
@deepaksftc deepaksftc self-assigned this Oct 31, 2024
@deepaksftc
Copy link

Hi @Cat-Lucifer, from what I understood, the 'View Proposal' button is used to just show the information that the 'User' has added as part of filling the proposals. Therefore, as per current logic, all the questions and answers which was part of the template, including the technique details will be displayed, but not instrument details. It's the same for non Xpress proposals also.
If we have to include instrument also, it would be an extra effort including adding STFC specific logics. Just wanted to confirm with you if it's is fine to go with the existing way.

image

@Cat-Lucifer
Copy link

@deepaksftc Yes, this is fine. Thanks.

@simonfernandes
Copy link
Contributor Author

Closed via UserOfficeProject/user-office-core#834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: uop/stfc/submissions An issue being handled by the STFC submissions team area: uop/stfc An issue relating to the STFC user office project.
Projects
None yet
Development

No branches or pull requests

3 participants