feat: Print logger messages to stdout in production #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jekabs-karklins
requested review from
simonfernandes
and removed request for
a team
jekabs-karklins
changed the title
…le-loggers-for-duo-
…le-loggers-for-duo-
Junjiequan
approved these changes
Jan 5, 2023
…le-loggers-for-duo-
…le-loggers-for-duo-
…le-loggers-for-duo-
…le-loggers-for-duo-
…le-loggers-for-duo-
jekabs-karklins
deleted the
SWAP-2884-add-ability-to-configure-multiple-loggers-for-duo-
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Print logger messages to stdout in production
Motivation and Context
Currently, you can only set one logger where to direct the logs.
For example for ESS in production, they are directed to Graylog.
This PR adds the ability to define multiple loggers, and all of them will be invoked when calling any of the ILogger methods.
This allows adding both Graylog and ConsoleLogger in the production, and Since
console.logfor NodeJS implementation is sending the stream tostdoutit will appear when inspecting container logs.If running In kubernetes this will now display the logger messages
kubectl logs
That should allow debugging issues quicker
How Has This Been Tested
Added unit tests for the library
Manually tested useroffice core for all scenarios
Fixes
https://jira.esss.lu.se/browse/SWAP-2884
Changes
Configuring logger with the new signature
Depends on
N/A