-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch stfc email to use status actions #711
feat: switch stfc email to use status actions #711
Conversation
I think this is a good step. In the future it would be good to make the SMTP service less STFC specific, at the moment you have hardcoded values from STFC in the file. |
Would be good to do the same for ELI and combine the SMTP services |
We will probably not need our ELI specific SMTP service, the specialized event handler would be enough if the SMTP service will be generic without STFC specific code. |
I think the best way to solve this is to allow upload of email templates then query the table for uploaded templates. Will create an issue for it. |
Description
This is a pull request to switch the STFC email to use status actions instead of the previously used method.
Motivation and Context
The previous method of handling STFC emails was cumbersome and prone to errors. There was also a need to clean up the code and improve readability. This change simplifies the email handling process and makes the code easier to maintain and understand.
Changes
The primary changes are done in two files:
SMTPMailService.ts
andstfcEmailHandler.ts
.SMTPMailService.ts
, the variable_email
has been renamed toemailTemplates
for clarity and better readability.stfcEmailHandler.ts
, several unnecessary imports, functions, and variables have been removed. This significantly simplifies the file, making it easier to understand and maintain.How Has This Been Tested?
Fixes
Part of : UserOfficeProject/issue-tracker#1011
Depends On
https://git.devs.facilities.rl.ac.uk/isisbusapps/BisAppSettings/pulls/453
Tests included/Docs Updated?