Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sorting button in experiments not functional #736

Conversation

yoganandaness
Copy link
Contributor

Description

In the Visitors table in the Experiment table, the sorting functionality is not working fine. This is the fix.

Motivation and Context

How Has This Been Tested

Added e2e test.

Fixes

Changes

Depends on

Tests included/Docs Updated?

  • [*] I have added tests to cover my changes.
  • All relevant doc has been updated

@yoganandaness yoganandaness requested a review from a team as a code owner September 3, 2024 16:21
@yoganandaness yoganandaness requested review from bashanlam and removed request for a team September 3, 2024 16:21
@yoganandaness
Copy link
Contributor Author

Uploading Screen Recording 2024-09-03 at 18.22.12.mov…

@yoganandaness yoganandaness changed the title Swap 4109 sorting button in experiments not functional swap 4109 sorting button in experiments not functional Sep 3, 2024
@yoganandaness yoganandaness changed the title swap 4109 sorting button in experiments not functional fix: sorting button in experiments not functional Sep 3, 2024
@yoganandaness yoganandaness requested review from a team and simonfernandes and removed request for a team September 13, 2024 11:33
Copy link
Contributor

@TCMeldrum TCMeldrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont use this feature but looks good

@yoganandaness yoganandaness merged commit 5e6c33e into develop Sep 18, 2024
19 checks passed
@yoganandaness yoganandaness deleted the SWAP-4109-uo-fe-sorting-button-in-experiments-not-functioni branch September 18, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants