-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sorting button in experiments not functional #736
Merged
yoganandaness
merged 11 commits into
develop
from
SWAP-4109-uo-fe-sorting-button-in-experiments-not-functioni
Sep 18, 2024
Merged
fix: sorting button in experiments not functional #736
yoganandaness
merged 11 commits into
develop
from
SWAP-4109-uo-fe-sorting-button-in-experiments-not-functioni
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoganandaness
requested review from
bashanlam
and removed request for
a team
September 3, 2024 16:21
Uploading Screen Recording 2024-09-03 at 18.22.12.mov… |
…ents-not-functioni
yoganandaness
changed the title
Swap 4109 sorting button in experiments not functional
swap 4109 sorting button in experiments not functional
Sep 3, 2024
yoganandaness
changed the title
swap 4109 sorting button in experiments not functional
fix: sorting button in experiments not functional
Sep 3, 2024
janosbabik
approved these changes
Sep 10, 2024
…ents-not-functioni
…ents-not-functioni
yoganandaness
requested review from
a team and
simonfernandes
and removed request for
a team
September 13, 2024 11:33
TCMeldrum
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we dont use this feature but looks good
…ents-not-functioni
…ents-not-functioni
…ents-not-functioni
yoganandaness
deleted the
SWAP-4109-uo-fe-sorting-button-in-experiments-not-functioni
branch
September 18, 2024 08:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the Visitors table in the Experiment table, the sorting functionality is not working fine. This is the fix.
Motivation and Context
How Has This Been Tested
Added e2e test.
Fixes
Changes
Depends on
Tests included/Docs Updated?