Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serving STFC PDFs from Postgres #779

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

simonfernandes
Copy link
Contributor

@simonfernandes simonfernandes commented Sep 19, 2024

Refs UserOfficeProject/issue-tracker#1163

  • Fix the postgres error we're seeing for invalid large-object descriptor
    • The problematic part was proposalPdfData.emit('end'); as proposalPdfData.pipe(res); has already closed the stream at that point
  • Refactor the db retrieval to add more robust error handling
  • Add logging so that we can see when a proposal was downloaded via postgres and whether it was successful or not

@simonfernandes simonfernandes requested review from a team and EdwardHaynes and removed request for a team September 19, 2024 10:56
@simonfernandes simonfernandes merged commit b95c4e6 into develop Sep 19, 2024
21 checks passed
@simonfernandes simonfernandes deleted the 1163-fix-stfc-pdfs branch September 19, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants