fix: using call submission message for customising successful proposal submission #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoganandaness
requested review from
deepaksftc and
janosbabik
and removed request for
a team
yoganandaness
changed the title
deepaksftc
approved these changes
Sep 25, 2024
janosbabik
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current implementation, the call submission message value is being used in incorrect place ie., in one of the warning messages. This has been removed and now being used where it is supposed to be used ie., during the proposal submission message.
Motivation and Context
Using Call Submission custom message correctly.
How Has This Been Tested
e2e
Fixes
Changes
Depends on
Tests included/Docs Updated?