Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insert all available user information at creation time #802

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

gnyiri
Copy link
Collaborator

@gnyiri gnyiri commented Oct 2, 2024

Description

Some user attributes are only updated after the second login of the user (first login will create the user in the users table, the second login will update the existing record).

Motivation and Context

It is confusing that some user attributes will only be set after the second login.

How Has This Been Tested

Manual testing + e2e.

Fixes

Synchronize the inserted / updated user attributes.

Changes

Update upsert method in OAuthAuthorization.ts.

Depends on

N/A

Tests included/Docs Updated?

  • [ x] I have added tests to cover my changes.
  • [ x] All relevant doc has been updated

@gnyiri gnyiri requested a review from a team as a code owner October 2, 2024 11:51
@gnyiri gnyiri requested review from mehta-pooja123 and removed request for a team October 2, 2024 11:51
Copy link
Contributor

@bolmsten bolmsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good improvement. We should go back and clean up the user table from all the unused values here

@gnyiri gnyiri merged commit 4ffaedc into develop Oct 2, 2024
19 checks passed
@gnyiri gnyiri deleted the fix_user_upsert branch October 2, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants