fix: replace browser alert/confirm with generic withConfirm wrapper in Questionary and StepView #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junjiequan
requested review from
mehta-pooja123
and removed request for
a team
Junjiequan
force-pushed
the
SWAP-3346-uo-in-proposal-review-trigger-back-button-shows-u
branch
from
79ade84 to
2ba2519
Compare
…ws-u' of https://github.com/UserOfficeProject/user-office-core into SWAP-3346-uo-in-proposal-review-trigger-back-button-shows-u
yoganandaness
approved these changes
Oct 8, 2024
Scott-James-Hurley
requested review from
Scott-James-Hurley
and removed request for
mehta-pooja123
…ack-button-shows-u
…ack-button-shows-u
…ack-button-shows-u
Scott-James-Hurley
approved these changes
Oct 15, 2024
…ack-button-shows-u
Junjiequan
deleted the
SWAP-3346-uo-in-proposal-review-trigger-back-button-shows-u
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the browser alert/confirm with a generic
withConfirmwrapper inQuestionaryandStepViewcomponents.Motivation and Context
The change is required to ensure a unified user experience across the application and to replace the default browser alert/confirm components, which are not user-friendly, with a custom-styled confirmation dialog.
Changes
Questionary.tsxandQuestionaryStepView.tsx, thewindow.confirmhas been replaced with thewithConfirmwrapper.QuestionarySubmissionState.tsanduseEventHandlers.tsfiles have been updated to handle the newconfirmprop passed to theBACK_CLICKED,RESET_CLICKED, andGO_TO_STEP_CLICKEDactions.QuestionaryandQuestionaryStepViewcomponents are now wrapped withwithConfirmat export.This change ensures that all confirmations within the
QuestionaryandStepViewcomponents are handled in a consistent and user-friendly manner.How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/SWAP-3346
Depends On
Tests included/Docs Updated?