Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fap review template preview #819

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

gnyiri
Copy link
Collaborator

@gnyiri gnyiri commented Oct 14, 2024

Description

Template preview for FAP review templates was missing.

Motivation and Context

FAP review template produced empty popup.

How Has This Been Tested

Manual tests.

Fixes

Add template preview for FAP review templates.

Changes

Add new stub for FAP review with questionary + change PreviewTemplateModal.tsx.

Depends on

N/A

Tests included/Docs Updated?

N/A

  • I have added tests to cover my changes.
  • All relevant doc has been updated

@gnyiri gnyiri requested a review from a team as a code owner October 14, 2024 13:06
@gnyiri gnyiri requested review from EdwardHaynes, ACLay, TCMeldrum and bolmsten and removed request for a team October 14, 2024 13:06
@gnyiri gnyiri requested a review from janosbabik October 16, 2024 09:48
@gnyiri gnyiri merged commit c9575e1 into develop Oct 18, 2024
19 checks passed
@gnyiri gnyiri deleted the fix_add_fap_review_template_preview branch October 18, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants