fix: intermittent xpress e2e failures #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonfernandes
requested review from
bashanlam
and removed request for
a team
simonfernandes
requested review from
a team,
Bhaswati1148 and
bolmsten
and removed request for
a team
ACLay
approved these changes
Oct 18, 2024
TCMeldrum
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses intermittent failures in Xpress end-to-end tests by adding a wait condition for instrument list loading.
Motivation and Context
The change is required to stabilize the end-to-end tests by ensuring that instrument list loading is complete before proceeding, thus preventing intermittent failures due to race conditions.
Changes
These changes aim to ensure the reliability of our end-to-end tests, providing more confidence in the stability and the quality of the overall application.
How Has This Been Tested?
Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On
Tests included/Docs Updated?