Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exchange avx2 to avx #22

Closed
V0ldek opened this issue May 24, 2022 · 1 comment · Fixed by #27
Closed

Exchange avx2 to avx #22

V0ldek opened this issue May 24, 2022 · 1 comment · Fixed by #27
Assignees
@V0ldek
Labels
enhancement New feature or request go ahead Reviewed, implementation can start good first issue Good for newcomers help wanted Extra attention is needed

Comments

@V0ldek
Copy link
Owner

V0ldek commented May 24, 2022

Is your feature request related to a problem? Please describe.

Currently there is feature detection for avx2 setting the SimdBlock to 32-byte (256-bit). But 256-wide vectors are enabled on avx already, so that should be enough to trigger the feature.

Tracking issue: #17

Describe the solution you'd like
Change avx2 target feature gates to avx.
@V0ldek V0ldek added enhancement New feature or request triage Waiting for owner's input labels May 24, 2022
@V0ldek V0ldek self-assigned this May 24, 2022
@V0ldek V0ldek mentioned this issue May 24, 2022
Open
@V0ldek V0ldek added help wanted Extra attention is needed good first issue Good for newcomers go ahead Reviewed, implementation can start and removed triage Waiting for owner's input labels May 26, 2022
@V0ldek
Copy link
Owner Author

V0ldek commented May 26, 2022

With the tests introduced in #18 this should be straightforward to test. Just add avx to the CI simd size test matrix for size 32.

@V0ldek V0ldek mentioned this issue May 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@V0ldek V0ldek

Labels
enhancement New feature or request go ahead Reviewed, implementation can start good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relax AVX2 requirement to AVX V0ldek/aligners
1 participant
@V0ldek