Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: generate strings in classifier tests #173

Merged
merged 1 commit into from
Jul 1, 2023
Merged

test: generate strings in classifier tests #173

merged 1 commit into from
Jul 1, 2023

Conversation

V0ldek
Copy link
Member

@V0ldek V0ldek commented Jul 1, 2023

Improve classifier correctness tests by including quoted strings with escapes in the generated proptest cases.

Originally by Ashish Barnaval @firewall2142.

Issue

Related: #20

Checklist

All of these should be ticked off before you submit the PR.

  • I ran just verify locally and it succeeded.
  • Issue was given go ahead and is linked above OR I have included justification for a minor change.
  • Unit tests for my changes are included OR no functionality was changed.

@firewall2142 @V0ldek
test: generate strings in classifier tests
dffd7f4 
Improve classifier correctness tests by including quoted strings with escapes
in the generated proptest cases.

Ref: #20

Co-authored-by: Mateusz Gienieczko <mat@gienieczko.com>
@V0ldek V0ldek merged commit 8b636d5 into main Jul 1, 2023
@V0ldek V0ldek deleted the #20-better-proptests-for-classification branch July 1, 2023 12:54
@V0ldek V0ldek mentioned this pull request Apr 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@V0ldek @firewall2142